Manage nonces pushed concurrency between SAN validation goroutines #454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hightoxicity
changed the title
hightoxicity
changed the title
|
Something even better would consist in pushing nonces under FQDN namespaces. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having certs with many SAN, we encounter a lot of errors with bad nonces.
Analyzing code we see that concurrency is managed on nonce pushed to nonces but not between launched in concurrency goroutines.
But several goroutines are managing in parallel the challenges and they pop the last pushed occurence of nonce, sometime the pop() happen bewteen first attempt and the retry and another goroutine pushed a new nonce, anonther one is about to use to make her own call.
To fix this issue, I set a mutex to allow only one goroutine at a time to deal with jws post + nonce stuff.