feat: add --replace-cert-domains flag to renew #2355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes go-acme#1532 When changing the --domains values, the certificate will not be refreshed to update the SANs appropriately. This change introduces a simple flag to check + enforce that the domains specified match exactly those in the certififcate during renewal.
|
It was suggested to me to name this option |
m1cr0man
changed the title
|
Done but I didn't squash it, as I would have to squash Idez' changes into mine. Can we squash merge on submit? |
|
The changes should be addressed through commits to ease the review, so no squash. I merge the PRs with the "squash and merge" button, so in the end, everything will be squashed, no need to "fixup". |
|
My nickname is LDEZ. |
Oh sorry, I should have double checked! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1532
When changing the --domains values, the certificate will not be refreshed to update the SANs appropriately.
This change introduces a simple flag to check + enforce that the domains specified match exactly those in the certificate during renewal.
I couldn't see a straightforward way to contribute a unit test for this, but I performed a full integration test using the NixOS ACME integration test suite. You can run that test locally with this command:
nix run github:m1cr0man/nixpkgs/lego-domain-testing#nixosTests.acme