Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DNS provider for Combell (reseller only) #1581

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ldez
Copy link
Member

@ldez ldez commented Feb 3, 2022

  • have a homogeneous design with the other providers
  • pass the linter
  • do go mod tidy
  • add tests (units)
  • add tests ("live")
  • add a provider descriptor
  • generate CLI help, documentation, and readme.
  • be able to do: (and put the output of this command to a comment)
rm -rf .lego/

COMBELL_API_KEY=xxx COMBELL_API_SECRET=yyy ./lego -m [email protected] --dns combell -d *.example.com -d example.com -s https://acme-staging-v02.api.letsencrypt.org/directory run

Note the wildcard domain is important.

@jwaes could you test by running the previous command (you have to use a real domain and email)?

Closes #1573

@ldez ldez added enhancement area/dnsprovider state/need-user-tests Need users to test functionality labels Feb 3, 2022
@jwaes
Copy link

jwaes commented Feb 4, 2022

blush ... now it turns out, that the combell API is only for resellers, not for 'ordinary' customers.
I guess i ll have to switch to a decent provider. Sorry for the work you put in.

@ldez
Copy link
Member Author

ldez commented Feb 4, 2022

Hello @jwaes, it seems like Combell has another API, related to OpenStack, if it's true maybe you can use Designate DNSaaS for Openstack.

@ldez ldez mentioned this pull request Feb 4, 2022
5 tasks
@ldez ldez changed the title Add DNS provider for Combell Add DNS provider for Combell (reseller only) Feb 4, 2022
@ldez ldez force-pushed the feat/combell branch 2 times, most recently from b423630 to 3416a6f Compare July 27, 2023 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

Support for provider: combell.com
3 participants