Skip to content

Commit

Permalink
review
Browse files Browse the repository at this point in the history
  • Loading branch information
@ldez
ldez committed Nov 19, 2024
1 parent d862ad7 commit e07a297
Show file tree
Hide file tree
Showing 14 changed files with 961 additions and 603 deletions.
318 changes: 119 additions & 199 deletions providers/dns/nicru/internal/client.go
View file

Large diffs are not rendered by default.

306 changes: 306 additions & 0 deletions providers/dns/nicru/internal/client_test.go
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,306 @@
package internal

import (
"context"
"fmt"
"io"
"net/http"
"net/http/httptest"
"net/url"
"os"
"path/filepath"
"testing"

"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
)

func setupTest(t *testing.T, pattern string, handler http.HandlerFunc) *Client {
t.Helper()

mux := http.NewServeMux()
server := httptest.NewServer(mux)
t.Cleanup(server.Close)

mux.HandleFunc(pattern, handler)

client, err := NewClient(server.Client(), "test")
require.NoError(t, err)

client.baseURL, _ = url.Parse(server.URL)

return client
}

func writeFixtures(method string, filename string, status int) http.HandlerFunc {
return func(rw http.ResponseWriter, req *http.Request) {
if req.Method != method {
http.Error(rw, fmt.Sprintf("unsupported method: %s", req.Method), http.StatusMethodNotAllowed)
return
}

file, err := os.Open(filepath.Join("fixtures", filename))
if err != nil {
http.Error(rw, err.Error(), http.StatusInternalServerError)
return
}

defer func() { _ = file.Close() }()

rw.WriteHeader(status)
_, err = io.Copy(rw, file)
if err != nil {
http.Error(rw, err.Error(), http.StatusInternalServerError)
return
}
}
}

func TestClient_GetZones(t *testing.T) {
client := setupTest(t, "/services/test/zones",
writeFixtures(http.MethodGet, "zones_GET.xml", http.StatusOK))

zones, err := client.GetZones(context.Background())
require.NoError(t, err)

expected := []Zone{
{
Admin: "123/NIC-REG",
Enable: "true",
HasChanges: "false",
HasPrimary: "true",
ID: "227645",
IDNName: "тест.рф",
Name: "xn—e1aybc.xn--p1ai",
Payer: "123/NIC-REG",
Service: "myservice",
},
{
Admin: "123/NIC-REG",
Enable: "true",
HasChanges: "false",
HasPrimary: "true",
ID: "227642",
IDNName: "example.ru",
Name: "example.ru",
Payer: "123/NIC-REG",
Service: "myservice",
},
{
Admin: "123/NIC-REG",
Enable: "true",
HasChanges: "false",
HasPrimary: "true",
ID: "227643",
IDNName: "test.su",
Name: "test.su",
Payer: "123/NIC-REG",
Service: "myservice",
},
}

assert.Equal(t, expected, zones)
}

func TestClient_GetZones_error(t *testing.T) {
client := setupTest(t, "/services/test/zones",
writeFixtures(http.MethodGet, "errors.xml", http.StatusOK))

_, err := client.GetZones(context.Background())
require.ErrorIs(t, err, Error{
Text: "Access token expired or not found",
Code: "4097",
})
}

func TestClient_GetRecords(t *testing.T) {
client := setupTest(t, "/services/test/zones/example.com./records",
writeFixtures(http.MethodGet, "records_GET.xml", http.StatusOK))

records, err := client.GetRecords(context.Background(), "example.com.")
require.NoError(t, err)

expected := []RR{
{
ID: "210074",
Name: "@",
IDNName: "@",
TTL: "",
Type: "SOA",
SOA: &SOA{
MName: &MName{
Name: "ns3-l2.nic.ru.",
IDNName: "ns3-l2.nic.ru.",
},
RName: &RName{
Name: "dns.nic.ru.",
IDNName: "dns.nic.ru.",
},
Serial: "2011112002",
Refresh: "1440",
Retry: "3600",
Expire: "2592000",
Minimum: "600",
},
},
{
ID: "210075",
Name: "@",
IDNName: "@",
Type: "NS",
NS: &NS{
Name: "ns3-l2.nic.ru.",
IDNName: "ns3- l2.nic.ru.",
},
},
{
ID: "210076",
Name: "@",
IDNName: "@",
Type: "NS",
NS: &NS{
Name: "ns4-l2.nic.ru.",
IDNName: "ns4-l2.nic.ru.",
},
},
{
ID: "210077",
Name: "@",
IDNName: "@",
Type: "NS",
NS: &NS{
Name: "ns8-l2.nic.ru.",
IDNName: "ns8- l2.nic.ru.",
},
},
}

assert.Equal(t, expected, records)
}

func TestClient_GetRecords_error(t *testing.T) {
client := setupTest(t, "/services/test/zones/example.com./records",
writeFixtures(http.MethodGet, "errors.xml", http.StatusOK))

_, err := client.GetRecords(context.Background(), "example.com.")
require.ErrorIs(t, err, Error{
Text: "Access token expired or not found",
Code: "4097",
})
}

func TestClient_AddRecord(t *testing.T) {
client := setupTest(t, "/services/test/zones/example.com./records",
writeFixtures(http.MethodPut, "records_PUT.xml", http.StatusOK))

rrs := []RR{
{
Name: "@",
Type: "NS",
NS: &NS{Name: "ns4-l2.nic.ru."},
},
{
Name: "@",
Type: "NS",
NS: &NS{Name: "ns8-l2.nic.ru."},
},
}

response, err := client.AddRecords(context.Background(), "example.com.", rrs)
require.NoError(t, err)

expected := []Zone{
{
Admin: "123/NIC-REG",
HasChanges: "true",
ID: "228095",
IDNName: "test.ru",
Name: "test.ru",
Service: "testservice",
RR: []RR{
{
ID: "210076",
Name: "@",
IDNName: "@",
Type: "NS",
NS: &NS{
Name: "ns4-l2.nic.ru.",
IDNName: "ns4-l2.nic.ru.",
},
},
{
ID: "210077",
Name: "@",
IDNName: "@",
Type: "NS",
NS: &NS{
Name: "ns8-l2.nic.ru.",
IDNName: "ns8-l2.nic.ru.",
},
},
},
},
}

assert.Equal(t, expected, response)
}

func TestClient_AddRecord_error(t *testing.T) {
client := setupTest(t, "/services/test/zones/example.com./records",
writeFixtures(http.MethodPut, "errors.xml", http.StatusOK))

rrs := []RR{
{
Name: "@",
Type: "NS",
NS: &NS{Name: "ns4-l2.nic.ru."},
},
{
Name: "@",
Type: "NS",
NS: &NS{Name: "ns8-l2.nic.ru."},
},
}

_, err := client.AddRecords(context.Background(), "example.com.", rrs)
require.ErrorIs(t, err, Error{
Text: "Access token expired or not found",
Code: "4097",
})
}

func TestClient_DeleteRecord(t *testing.T) {
client := setupTest(t, "/services/test/zones/example.com./records/123",
writeFixtures(http.MethodDelete, "record_DELETE.xml", http.StatusUnauthorized))

err := client.DeleteRecord(context.Background(), "example.com.", "123")
require.NoError(t, err)
}

func TestClient_DeleteRecord_error(t *testing.T) {
client := setupTest(t, "/services/test/zones/example.com./records/123",
writeFixtures(http.MethodDelete, "errors.xml", http.StatusUnauthorized))

err := client.DeleteRecord(context.Background(), "example.com.", "123")
require.ErrorIs(t, err, Error{
Text: "Access token expired or not found",
Code: "4097",
})
}

func TestClient_CommitZone(t *testing.T) {
client := setupTest(t, "/services/test/zones/example.com./commit", writeFixtures(http.MethodPost, "commit_POST.xml", http.StatusOK))

err := client.CommitZone(context.Background(), "example.com.")
require.NoError(t, err)
}

func TestClient_CommitZone_error(t *testing.T) {
client := setupTest(t, "/services/test/zones/example.com./commit", writeFixtures(http.MethodPost, "errors.xml", http.StatusOK))

err := client.CommitZone(context.Background(), "example.com.")
require.ErrorIs(t, err, Error{
Text: "Access token expired or not found",
Code: "4097",
})
}
4 changes: 4 additions & 0 deletions providers/dns/nicru/internal/fixtures/commit_POST.xml
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="UTF-8" ?>
<response>
<status>success</status>
</response>
7 changes: 7 additions & 0 deletions providers/dns/nicru/internal/fixtures/errors.xml
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
<?xml version="1.0" encoding="UTF-8" ?>
<response>
<status>fail</status>
<errors>
<error code="4097">Access token expired or not found</error>
</errors>
</response>
4 changes: 4 additions & 0 deletions providers/dns/nicru/internal/fixtures/record_DELETE.xml
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
<?xml version="1.0" encoding="UTF-8" ?>
<response>
<status>success</status>
</response>
55 changes: 55 additions & 0 deletions providers/dns/nicru/internal/fixtures/records_GET.xml
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,55 @@
<?xml version="1.0" encoding="UTF-8" ?>
<response>
<status>success</status>
<data>
<zone admin="123/NIC-REG" has-changes="true" id="228095" idn-name="test.ru" name="test.ru" service="myservice">
<rr id="210074">
<name>@</name>
<idn-name>@</idn-name>
<type>SOA</type>
<soa>
<mname>
<name>ns3-l2.nic.ru.</name>
<idn-name>ns3-l2.nic.ru.</idn-name>
</mname>
<rname>
<name>dns.nic.ru.</name>
<idn-name>dns.nic.ru.</idn-name>
</rname>
<serial>2011112002</serial>
<refresh>1440</refresh>
<retry>3600</retry>
<expire>2592000</expire>
<minimum>600</minimum>
</soa>
</rr>
<rr id="210075">
<name>@</name>
<idn-name>@</idn-name>
<type>NS</type>
<ns>
<name>ns3-l2.nic.ru.</name>
<idn-name>ns3- l2.nic.ru.</idn-name>
</ns>
</rr>
<rr id="210076">
<name>@</name>
<idn-name>@</idn-name>
<type>NS</type>
<ns>
<name>ns4-l2.nic.ru.</name>
<idn-name>ns4-l2.nic.ru.</idn-name>
</ns>
</rr>
<rr id="210077">
<name>@</name>
<idn-name>@</idn-name>
<type>NS</type>
<ns>
<name>ns8-l2.nic.ru.</name>
<idn-name>ns8- l2.nic.ru.</idn-name>
</ns>
</rr>
</zone>
</data>
</response>
10 changes: 10 additions & 0 deletions providers/dns/nicru/internal/fixtures/records_PUT.xml
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
<?xml version="1.0" encoding="UTF-8" ?>
<response>
<status>success</status>
<data>
<zone admin="123/NIC-REG" has-changes="true" id="228095" idn-name="test.ru" name="test.ru" service="testservice">
<rr id="210076"><name>@</name><idn-name>@</idn-name><type>NS</type><ns><name>ns4-l2.nic.ru.</name><idn-name>ns4-l2.nic.ru.</idn-name></ns></rr>
<rr id="210077"><name>@</name><idn-name>@</idn-name><type>NS</type><ns><name>ns8-l2.nic.ru.</name><idn-name>ns8-l2.nic.ru.</idn-name></ns></rr>
</zone>
</data>
</response>
Loading

0 comments on commit e07a297

Please sign in to comment.