Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: addressability #4053

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

petar-dambovaliev
Copy link
Contributor

@petar-dambovaliev petar-dambovaliev commented Apr 3, 2025

@jaekwon said this should be covered by the Go typechecker and this code should be reverted while keeping the tests that were added with this functionality.

@Gno2D2
Copy link
Collaborator

Gno2D2 commented Apr 3, 2025

🛠 PR Checks Summary

All Automated Checks passed. ✅

Manual Checks (for Reviewers):
  • IGNORE the bot requirements for this PR (force green CI check)
Read More

🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers.

✅ Automated Checks (for Contributors):

No automated checks match this pull request.

☑️ Contributor Actions:
  1. Fix any issues flagged by automated checks.
  2. Follow the Contributor Checklist to ensure your PR is ready for review.
    • Add new tests, or document why they are unnecessary.
    • Provide clear examples/screenshots, if necessary.
    • Update documentation, if required.
    • Ensure no breaking changes, or include BREAKING CHANGE notes.
    • Link related issues/PRs, where applicable.
☑️ Reviewer Actions:
  1. Complete manual checks for the PR, including the guidelines and additional checks if applicable.
📚 Resources:
Debug
Manual Checks
**IGNORE** the bot requirements for this PR (force green CI check)

If

🟢 Condition met
└── 🟢 On every pull request

Can be checked by

  • Any user with comment edit permission

Copy link

codecov bot commented Apr 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

Copy link
Contributor

@ltzmaxwell ltzmaxwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CI failed. Additionally, keeping the addressable* prefixed tests while displaying unrelated error output can be misleading.

@thehowl
Copy link
Member

thehowl commented Apr 4, 2025

We likely need to explicitly make the tests that should fail in typecheck run the typecheck

@Kouteki Kouteki moved this from Triage to In Review in 🧙‍♂️gno.land core team Apr 7, 2025
@ltzmaxwell
Copy link
Contributor

ltzmaxwell commented Apr 7, 2025

I think some of the originally added test files are valuable (that’s why they should be kept).
I believe the positive test cases should be preserved. The negative test cases need to be reviewed, and the test file names and their error messages should be updated accordingly(because there's not addressability check in the stack after revert).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 🤖 gnovm Issues or PRs gnovm related
Projects
Status: In Progress
Status: In Review
Development

Successfully merging this pull request may close these issues.

4 participants