-
Notifications
You must be signed in to change notification settings - Fork 404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
revert: addressability #4053
base: master
Are you sure you want to change the base?
revert: addressability #4053
Conversation
🛠 PR Checks SummaryAll Automated Checks passed. ✅ Manual Checks (for Reviewers):
Read More🤖 This bot helps streamline PR reviews by verifying automated checks and providing guidance for contributors and reviewers. ✅ Automated Checks (for Contributors):No automated checks match this pull request. ☑️ Contributor Actions:
☑️ Reviewer Actions:
📚 Resources:Debug
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CI failed. Additionally, keeping the addressable*
prefixed tests while displaying unrelated error output can be misleading.
We likely need to explicitly make the tests that should fail in typecheck run the typecheck |
I think some of the originally added test files are valuable (that’s why they should be kept). |
@jaekwon said this should be covered by the Go typechecker and this code should be reverted while keeping the tests that were added with this functionality.