Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade Komorebi client to v0.1.26 #59

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

CtByte
Copy link

@CtByte CtByte commented May 1, 2024

I intend to address an issue that is now fixed with Komorebi and Stackbar, as @LGUG2Z was kind enough to create a new release when this issue was fixed, just to make things faster.

This also helps those who upgrade Komorebi to a higher version compared to what is currently being used by Zebar, see #52.

@adriankarlen
Copy link

I'm not sure if komorebi is using semantic versioning but would it not make sense to wildcard the minor version, assuming that it is not a breaking change most of the time?

Perhaps @LGUG2Z can give some clarity on the versioning of komorebi, but it feels unsustainable to keep bumping for every bugfix in komorebi.

@LGUG2Z
Copy link
Contributor

LGUG2Z commented May 13, 2024

These are not bugfix releases; the last few releases have seen some major additions to the state format with the introduction of features like the Stackbar.

What I think makes sense here is for Zebar and other integrators who only care about a small subset of the state to wrap the notifications received in structs that only specify the fields they are interested in, and then deserialize the notifications to that struct.

@CtByte
Copy link
Author

CtByte commented May 14, 2024

I can see that I should have clarified the purpose of this PR in the description. I will fix that now.

I agree that the Komorebi integration could be more flexible as to what fields to map. In this particular case, the new Komorebi version also added a new layout type that is probably better to include, rather than make a workaround to ignore it.

@LGUG2Z
Copy link
Contributor

LGUG2Z commented May 23, 2024

Might as well bump this PR to tag v0.1.26 now

@CtByte
Copy link
Author

CtByte commented May 23, 2024

Sure, I will test it a bit first 😉

Edit: I've made the necessary adjustments for komorebi v0.1.26

@LGUG2Z Congrats on the release 🎉

@CtByte CtByte changed the title komorebi v0.1.25 komorebi v0.1.26 May 23, 2024
@lars-berger lars-berger changed the title komorebi v0.1.26 chore: upgrade Komorebi client to v0.1.26 May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants