feat: Validate Proxy-Authorization credentials (#52)#59
Open
feat: Validate Proxy-Authorization credentials (#52)#59
Conversation
- Add PROXY_AUTH_USERNAME and PROXY_AUTH_PASSWORD to Settings (optional) - When both are configured, validate Proxy-Authorization: Basic header - Return 407 Proxy Authentication Required on mismatch - Backward compatible: skip validation if either setting is empty - Parse Basic auth (case-insensitive scheme, supports colons in password) - 22 new tests, 210 total passing Closes #52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add optional Proxy-Authorization validation so the Home Node can verify that inbound requests come from an authorized Gateway.
Changes
app/config.py: NewPROXY_AUTH_USERNAMEandPROXY_AUTH_PASSWORDsettings (default empty)app/proxy_handler.py:_proxy_auth_required()— returns 407 response_parse_basic_auth()— decodesProxy-Authorization: Basic <b64>headershandle_client()before CONNECT/HTTP forward dispatchHow it works
endpoint_url:https://user:pass@1.2.3.4:9090Proxy-Authorization: Basic <b64>to Home NodeSR_PROXY_AUTH_USERNAME/SR_PROXY_AUTH_PASSWORDTests
tests/test_proxy_auth.pyDepends on: PR #58 (Request-ID tracing)
Closes #52