Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force rustup to install missing toolchain b/c it broke all of our builds #574

Merged
merged 1 commit into from
Mar 4, 2025

Conversation

atodorov
Copy link
Contributor

@atodorov atodorov commented Mar 4, 2025

From its changelog:
https://github.com/rust-lang/rustup/blob/master/CHANGELOG.md#1280---2025-03-04

rustup will no longer automatically install the active toolchain if it is not installed. pr#3985
To ensure its installation, run rustup toolchain install with no arguments.

Description of proposed changes


Practical tips for PR review & merge:

  • All GitHub Actions report PASS
  • Newly added code/functions have unit tests
    • Coverage tools report all newly added lines as covered
    • The positive scenario is exercised
    • Negative scenarios are exercised, e.g. assert on all possible errors
    • Assert on events triggered if applicable
    • Assert on changes made to storage if applicable
  • Modified behavior/functions - try to make sure above test items are covered
  • Integration tests are added if applicable/needed

From its changelog:
https://github.com/rust-lang/rustup/blob/master/CHANGELOG.md#1280---2025-03-04

> rustup will no longer automatically install the active toolchain if it is not installed. pr#3985
> To ensure its installation, run rustup toolchain install with no arguments.
Copy link

github-actions bot commented Mar 4, 2025

For full LLVM coverage report click here!

@atodorov atodorov merged commit 5ec0d52 into dev Mar 4, 2025
51 of 53 checks passed
@atodorov atodorov deleted the fix-rustup-issues branch March 4, 2025 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants