Update polkadot-sdk to stable-2409 #566
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For full LLVM coverage report click here! |
beqaabu
force-pushed
the
forks-backup
branch
6 times, most recently
from
75954cb to
a719873
Compare
atodorov
reviewed
Feb 10, 2025
beqaabu
force-pushed
the
forks-backup
branch
4 times, most recently
from
ab1ea9d to
a119957
Compare
atodorov
requested changes
Feb 13, 2025
beqaabu
requested review from
atodorov,
DylanVerstraete,
BradleyOlson64 and
rustlang-dev
|
only the flaky smart contract tool test is failing https://github.com/gluwa/creditcoin3/actions/runs/13307767960/job/37163278848?pr=566. side note it is passing lcoally |
atodorov
requested changes
Feb 13, 2025
I'll update this pr, would be cleaner |
BradleyOlson64
previously approved these changes
Feb 13, 2025
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
b/c an actual iteration of this for loop may span between 2 consequtive blocks, or right around the edges of block time!
beqaabu
force-pushed
the
forks-backup
branch
from
6c8a754 to
2c65250
Compare
atodorov
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Updates polkadot-sdk dependencies to `stable-2409`, removes vendored tracing crates and uses moonbeam's tracing instead. Introduces a couple of breaking changes on the client's side, such as nodes that are using tracing features wont be able to use them unless they update their client to the latest version, after the runtime upgrade. full list of changes can be seen [here](https://gluwa.atlassian.net/wiki/spaces/CB/pages/1464074248/CC3+PolkadotSDK+and+Frontier+Upgrade)Practical tips for PR review & merge: