Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSUB-1374: Tell gitleaks to scan only commits in the current PR #529

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

atodorov
Copy link
Contributor

Description of proposed changes


Practical tips for PR review & merge:

  • All GitHub Actions report PASS
  • Newly added code/functions have unit tests
    • Coverage tools report all newly added lines as covered
    • The positive scenario is exercised
    • Negative scenarios are exercised, e.g. assert on all possible errors
    • Assert on events triggered if applicable
    • Assert on changes made to storage if applicable
  • Modified behavior/functions - try to make sure above test items are covered
  • Integration tests are added if applicable/needed

Copy link

For full LLVM coverage report click here!

@atodorov atodorov force-pushed the testing/CSUB-1374-make-gitleaks-check-only-pr-branch branch 2 times, most recently from fa543b9 to 602595a Compare November 20, 2024 13:19
@atodorov atodorov force-pushed the testing/CSUB-1374-make-gitleaks-check-only-pr-branch branch from 602595a to 0b2da77 Compare November 20, 2024 13:25
@atodorov
Copy link
Contributor Author

TEST RESULTS:

  1. With a685ce5 included then MegaLinter + gitleaks reports FAIL, as expected, see https://github.com/gluwa/creditcoin3/actions/runs/11934332498/job/33263220586?pr=529. Note: this is the commit which initially introduced this issue into the repository, Handle polkadot forks #483 (comment).

  2. Without the commit mentioned above, MegaLinter + gitleaks reports PASS, https://github.com/gluwa/creditcoin3/actions/runs/11934233925/job/33262918284.

These results should be evidence that gitleaks is looking only into the commits from the current PR that MegaLinter is operating upon, instead of all commits, from all branches currently present in the repository!

@atodorov atodorov force-pushed the testing/CSUB-1374-make-gitleaks-check-only-pr-branch branch from 0b2da77 to ea30bcb Compare November 20, 2024 13:32
@atodorov atodorov marked this pull request as ready for review November 20, 2024 14:04
Copy link
Contributor

@beqaabu beqaabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

unrelated to this pr but the ci is failing on deploying contracts with hardhat, see https://github.com/gluwa/creditcoin3/actions/runs/11934458057/job/33264244676?pr=529

@atodorov
Copy link
Contributor Author

unrelated to this pr but the ci is failing on deploying contracts with hardhat, see https://github.com/gluwa/creditcoin3/actions/runs/11934458057/job/33264244676?pr=529

Yes, I am aware of this. Will be resolved in https://gluwa.atlassian.net/browse/CSUB-1368

@atodorov atodorov merged commit 8fc36eb into dev Nov 21, 2024
52 of 53 checks passed
@atodorov atodorov deleted the testing/CSUB-1374-make-gitleaks-check-only-pr-branch branch November 21, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants