Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSUB-961: Add ability to initiate payout for the pool #40

Draft
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

zacharyfrederick
Copy link
Contributor

No description provided.

Copy link
Contributor

Test before merge -> Staking Dashboad Preview!

Copy link
Contributor

@atodorov atodorov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO it makes sense to show how much the rewards are for each era (or grand total whenever the batch functionality becomes available). As a user I will not want to pay high fees to initiate payouts only to find out that my reward is lower than the fees I paid.

See how it looks like if you are nominating directly and claiming your rewards:
image

I deally when I am a pool member I will be able to see:

  • rewards per era (earned only by the pool)
  • what I am seeing (should be annotated appropriately) is my personal chunk of the pool reward or a relatively close approximation (claiming rewards from a pool already shows only your personal chunk)

More items:

  • once I request a payout for a specific era and the transaction makes it into a block the state of this widget needs to be updated. I was able to request payouts for era 209 3 times in a row without seeing errors

@atodorov atodorov marked this pull request as draft January 8, 2024 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants