Open
Conversation
|
Mind commenting further on when we would use this for testing vs spinning up a local network? |
atodorov
requested changes
Mar 2, 2026
Contributor
atodorov
left a comment
atodorov
left a comment
There was a problem hiding this comment.
Couple comments, I think one of them has the potential to break existing creditcoin3 CI jobs.
Also see failing CI jobs.
| spec.set_state( | ||
| storage_prefix("Sudo", "Key"), | ||
| "0xd43593c715fdd31c61141abd04a99fd6822c8558854ccde39a5684e7a56da27d".to_owned(), | ||
| ); |
Contributor
There was a problem hiding this comment.
This tool is also used in gluwa/creditcoin3 so removing existing behavior will most likely break things. IMO you should return this back.
src/main.rs
Outdated
| { | ||
| spec.set_state(k, v.clone()); | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Not sure if this will continue working with creditcoin3. Looks like it will but we'll have to test it out and if it doesn't need to make more changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supports forking USC network for easy debugging and attestor network bootstrapping