Skip to content
This repository has been archived by the owner on Apr 30, 2020. It is now read-only.

Update Travis to build and push the operator container #45

Merged
merged 4 commits into from
Dec 16, 2018

Conversation

JohnStrunk
Copy link
Member

Describe what this PR does
This updates the Travis-CI configuration to build the container image for the operator, and, if successful, it will push the image to quay.io

Is there anything that requires special attention?
no

Related issues:

@JohnStrunk JohnStrunk requested a review from sac December 16, 2018 21:10
@ghost ghost assigned JohnStrunk Dec 16, 2018
@ghost ghost added the in progress label Dec 16, 2018
Copy link
Collaborator

@jarrpa jarrpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to see more scripting such that the linters can be reproduced locally before sending them off to Travis, but that can come in another PR. The PR LGTM as is, but I'd like to ask: how are the QUAY_ and DOCKER_ variables set in Travis? Is that configured privately on the Travis end?

@jarrpa jarrpa merged commit 9aac4e1 into gluster:master Dec 16, 2018
@ghost ghost removed the in progress label Dec 16, 2018
@JohnStrunk
Copy link
Member Author

I'd like to ask: how are the QUAY_ and DOCKER_ variables set in Travis?

They are set in the Travis settings on the website. Since these are sensitive, they can't be set in the standard env block. They must either be encrypted in the yaml or set on the web settings page. While the settings page isn't version controlled, it's much easier to see the config and change it.

@jarrpa
Copy link
Collaborator

jarrpa commented Dec 17, 2018

They are set in the Travis settings on the website. Since these are sensitive, they can't be set in the standard env block. They must either be encrypted in the yaml or set on the web settings page. While the settings page isn't version controlled, it's much easier to see the config and change it.

Makes total sense, wanted to make sure it wasn't just assumption. ;)

@JohnStrunk JohnStrunk deleted the autobuild branch December 19, 2018 14:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants