Skip to content
This repository has been archived by the owner on Apr 30, 2020. It is now read-only.

Add Travis-ci w/ linters #33

Merged
merged 3 commits into from
Jul 12, 2018
Merged

Add Travis-ci w/ linters #33

merged 3 commits into from
Jul 12, 2018

Conversation

JohnStrunk
Copy link
Member

@JohnStrunk JohnStrunk commented Jul 11, 2018

Describe what this PR does
Adds an initial Travis-CI build that lints all markup and shell scripts

Is there anything that requires special attention?
Currently, there's only a linter stage in Travis. Once we get code, we can add the test/coverage

Related issues:
#31

Adds --require-all flag to the pre-commit linter that will cause the
script to fail if one of the checkers can't be found. This is added to
ensure Travis fails if something goes wrong with installing prereqs as
opposed to silently skipping the checks.

Signed-off-by: John Strunk <[email protected]>
@JohnStrunk JohnStrunk changed the title [WIP] Add Travis-ci w/ linters Add Travis-ci w/ linters Jul 11, 2018
@JohnStrunk JohnStrunk requested a review from jarrpa July 11, 2018 20:56
Copy link
Collaborator

@jarrpa jarrpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know these tools very well, but from what little I do know they look in order. Good enough for me, let's see how they fare.

@JohnStrunk JohnStrunk merged commit 771824a into gluster:master Jul 12, 2018
@JohnStrunk JohnStrunk deleted the travis branch July 12, 2018 14:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants