Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix - Verification of adding follow-ups for users who are in a ticket… #17934

Conversation

RomainLvr
Copy link
Contributor

Checklist before requesting a review

Please delete options that are not relevant.

  • I have read the CONTRIBUTING document.
  • I have performed a self-review of my code.
  • I have added tests that prove my fix is effective or that my feature works.
  • This change requires a documentation update.

Description

  • It fixes !34517
  • Here is a brief description of what this PR does

If a user is part of a group defined as an observer in a ticket, they cannot add a follow-up to this ticket.

If the user is added directly as an individual observer, adding follow-up works correctly.

The problem occurs even if the following options are checked in the user's profile:

  • Add follow-up (associated groups)
  • Add follow-up (observer)

The same problem occurs with the self-service profile

Copy link
Member

@cedric-anne cedric-anne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update the testCanAddFollowupsAsObserver() method to test this case too ?

@trasher trasher merged commit 3d0e1fa into glpi-project:10.0/bugfixes Sep 26, 2024
6 checks passed
@cedric-anne cedric-anne added this to the 10.0.17 milestone Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants