Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding custom cluster separable job name option #262

Merged
merged 2 commits into from
Mar 3, 2020

Conversation

ac-optimus
Copy link
Contributor

@ac-optimus ac-optimus commented Feb 29, 2020

fixes #224

Description

Motivation and Context

Types of Changes

  • Documentation update
  • Bug fix
  • New feature
  • Breaking change1

1The change breaks (or has the potential to break) existing functionality.

Checklist:

If necessary:

  • I have updated the API documentation as part of the package doc-strings.
  • I have created a separate pull request to update the framework documentation on signac-docs and linked it here.
  • I have updated the changelog.

@ac-optimus ac-optimus requested review from a team as code owners February 29, 2020 13:56
Copy link
Member

@b-butler b-butler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@b-butler
Copy link
Member

b-butler commented Mar 3, 2020

@bdice approves.

@b-butler b-butler merged commit 161a661 into glotzerlab:master Mar 3, 2020
@csadorf
Copy link
Contributor

csadorf commented Mar 4, 2020

How would a user find out about this feature?

@bdice
Copy link
Member

bdice commented Mar 16, 2020

How would a user find out about this feature?

@csadorf I think that's a good question. I created an issue with a suggestion for documenting this. I'm open to alternative ideas as well: glotzerlab/signac-docs#81

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cluster-customizable separators in job names
4 participants