add backward-compatibility hack for command-line parsing #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This slightly changes tlapm's command-line syntax in an incompatible way: - deprecated options are no longer accepted: `-d`, `--paranoid`, `--isaprove`, `--fpdir` - options that used to take two arguments (as in `--opt A B`) now takes them as a single comma-separated argument (as in `--opt A,B`): `--toolbox`, `--nofpl`, `--erasefp` Signed-off-by: Stephane Glondu <[email protected]>
- "--toolbox A B" becomes "--toolbox A,B" - "--isaprove" is deprecated and no longer supported Signed-off-by: Stephane Glondu <[email protected]>
This gives to reverse-dependencies the ability to auto-detect which command-line syntax to use. Signed-off-by: Stephane Glondu <[email protected]>
Signed-off-by: Damien Doligez <[email protected]>
glondu
force-pushed
the
cmdliner-tlapm
branch
from
fc037ec to
319d2a1
Compare
|
Thanks for the tip! I propose a different implementation which is (IMHO) easier to read: 319d2a1 |
glondu
force-pushed
the
cmdliner-tlapm
branch
2 times, most recently
from
d7b988e to
178acd7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Damien Doligez [email protected]
This is a PR on tlaplus#177 to add backward compatiblity with double-argument command line options.
The idea is to scan the command line to detect old-style usage and (if needed) modify the command line to make it parseable by Cmdliner.
It's not a lot of code, and it will let users upgrade TLAPM while staying with the old toolbox.