WIP: Add '#nohusky' tag to Brakeman #521
Open
+39
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to add '#nohusky' tag to Ruby's files to avoid false positives.
Closes #508
Proposed Changes
api/securitytest/brakeman.go
: addVerifyNoHusky
logicapi/util/util.go
: here I usedbanditCase
func to Brakeman files. If it is the right approach, I think thebanditCase
could be renamed.api/util/util_test.go
: add some unit tests. All tests passed.Testing
I've tried to test my implementations with the step below:
In
.env
:After:
But, after this test it seems that my changes doesn't reflect in it.
Sample of output: