-
Notifications
You must be signed in to change notification settings - Fork 45
Protect processing of custom scripts in glidein_startup against stdin interference #498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Protect processing of custom scripts in glidein_startup against stdin interference #498
Conversation
…leshoot file fetching
1c3b9bc
to
09cfe1a
Compare
To help troubleshoot:
This will add about 20+2*N_of_downloads lines to the glidein stderr |
New version (3). Added a wrapper in the read loop parsing the files to get more troubleshooting info: https://raw.githubusercontent.com/glideinWMS/glideinwms/9642ae5dc1828ddd04b677f40611fc2d8f2f1992/creation/web_base/glidein_startup.sh |
Small improvements to other scripts
a38d003
to
cf01acc
Compare
This fix will go in GlideinWMS (Factory) v 3.10.11 and v 3.11.1
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good and can be merged!
As reported in Issue #500 , on a specific site the parsing of the client custom scripts list was stopping after a specific file and continuing with the next list.
This PR fixes #500 :
The last commit is the fix for production
This PR includes also older commits with modified versions used in troubleshooting (debug messages). To keep them in the history.
Consider a squash-merge to exclude them from the master branch history.