Fix scrolling by pixels

glideapps · May 9, 2024 · 6bed93f · 6bed93f
1 parent 3a97523
commit 6bed93f
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 2 deletions.
diff --git a/packages/core/src/data-editor/data-editor.tsx b/packages/core/src/data-editor/data-editor.tsx
@@ -1496,8 +1496,8 @@ const DataEditorImpl: React.ForwardRefRenderFunction<DataEditorRef, DataEditorPr
                         height: 0,
                     };
 
-                    let scrollX = 0;
-                    let scrollY = 0;
+                    let scrollX = desiredX ?? 0;
+                    let scrollY = desiredY ?? 0;
 
                     if (trueCol !== undefined || trueRow !== undefined) {
                         targetRect = grid.getBounds((trueCol ?? 0) + rowMarkerOffset, trueRow ?? 0) ?? targetRect;

diff --git a/packages/core/src/docs/examples/imperative-scroll.stories.tsx b/packages/core/src/docs/examples/imperative-scroll.stories.tsx
@@ -42,6 +42,16 @@ export const ImperativeScroll: React.VFC<ImperativeScrollProps> = p => {
         });
     };
 
+    const pixels = 1_000_000_000;
+    const onClickEnd = () => {
+        ref.current?.scrollTo({
+            amount: pixels,
+            unit: "px",
+        },
+        0,
+        "horizontal");
+    };
+
     return (
         <BeautifulWrapper
             title="Imperative scrolling"
@@ -54,6 +64,9 @@ export const ImperativeScroll: React.VFC<ImperativeScrollProps> = p => {
                     <MoreInfo>
                         Click <button onClick={onClick}>Here</button> to scroll to column 4 row 100
                     </MoreInfo>
+                    <MoreInfo>
+                        Click <button onClick={onClickEnd}>Here</button> to scroll by {pixels} pixels
+                    </MoreInfo>
                 </>
             }>
             <DataEditor