-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add URL to luxon text #176
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@cif, not sure how to run glide locally and use this branch to test that my change is working properly in the product. Any tips? |
For that change to render a link I suspect we'd have to convert the markdown in the string to HTML in the property configuration. If you create an issue for that I can look into it, might be a pretty simple change |
Created the issue here: https://github.com/glideapps/glide/issues/25182 I just added the URL to see if it would work. I saw that there was a URL previously stored in Screenshots |
Commented in the issue as well https://github.com/glideapps/glide/issues/25182#issuecomment-1910436021. Adding the markdown to the description field will be the way we want to enable this - the builder ignores the about field for yes code configs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving ahead of https://github.com/glideapps/glide/pull/25188 needing to land in production, which I believe should happen today.
Nice! Do you want to merge this or should I once the other PR lands? |
Looks like the prod deploy hasn't started yet and I'll be offline for a few hours. If you see it land feel to merge! |
It landed! I would merge, but I'm not authorized apparently. Can you give me permissions? |
I also lack permissions here, @timwellswa can you give us a hand when you get a second? |
Context
Make it easier to understand luxon date formatting by adding a hyperlink
Screenshot