Allow seperate app versions under an Umbrella #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ioning Allow seperate app versioning under umbrellas
…ioning Push multiple tags
…ioning Better handling of multiple tags
…ioning Use correct nested change descriptions
|
Hi! Would it be OK to merge this PR? That's pretty much exactly what I need in my project 😊 Cheers! |
I would be happy to, but I do not maintain the repo |
|
@Theuns-Botha Yeah I know. While we wait, do you mind if I actually write a couple comments on your code? I was looking at it and I have a couple suggestions. |
bdubaut
reviewed
Mar 17, 2021
| end | ||
| end | ||
|
|
||
| defp bump_multiple() do |
There was a problem hiding this comment.
It could make sense to try to split this one into smaller functions so that it's a bit more understandable what it does, wdyt ?
Comment on lines
+28
to
+61
| {:ok, sub_apps} -> | ||
| sub_apps = Map.put(sub_apps, :umbrella, ".") | ||
|
|
||
| changes = Enum.map(sub_apps, fn | ||
|
|
||
| {:umbrella, app_path} -> | ||
| # Note changes re required for the umbrella app | ||
| {current_version, new_version, changelog_entries} = get_changes(app_path, :normal) | ||
| {:umbrella, app_path, current_version, new_version, changelog_entries} | ||
|
|
||
| {app, app_path} -> | ||
|
|
||
| say "\n\n==============================================" | ||
| say "Bump details for #{Atom.to_string(app)}" | ||
| say "==============================================" | ||
|
|
||
| get_changes(app_path, :multi) | ||
| |> case do | ||
| nil -> nil | ||
| {current_version, new_version, changelog_entries} -> | ||
| {app, app_path, current_version, new_version, changelog_entries} | ||
| end | ||
|
|
||
|
|
||
| end) | ||
| |> Enum.filter(fn(change) -> not is_nil(change) end) | ||
|
|
||
| if allow_changes?(changes) do | ||
| make_changes(changes) | ||
| end | ||
|
|
||
| {:error, :unknown_app_structure} -> | ||
| say "Please note that only standard umbrella app directory structures are supported. Please refer to the documentation for details", :red | ||
| end |
There was a problem hiding this comment.
I reckon this could be used with a with statement and relying on pattern matching to do the thing.
Comment on lines
+50
to
+55
| umbrella_changes = Enum.find(commit_changes, | ||
| fn({app, app_path, current_version, new_version, changelog_entries}) -> | ||
| app == :umbrella | ||
| end | ||
| ) | ||
| app_changes = List.delete(commit_changes, umbrella_changes) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.