-
-
Notifications
You must be signed in to change notification settings - Fork 867
Feat: Added support for configuring Docker containers through glance.yaml instead of labels #453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Added support for configuring Docker containers through glance.yaml instead of labels #453
Conversation
Hey, thanks for contributing! This is something I want to add support for, however before doing that I think we need to have a discussion around how it would work in conjunction with this feature, since that does mean that you may end up with multiple containers having the same name. |
@svilenmarkov I think one way we can support this with the feature you linked is to extend it by adding an optional
Then we can specify the
If a Or we can even extend the name to just have the provider name included as part of the human readable option. E.g. using the above config: How does that sound? |
i like arrays more containers:
- name: glance # This is the actual container name
provider: glance-socket
title: "Test Glances Name"
... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm dropping the plan to add merging container data from multiple sources for now, as it makes things much more complicated and confusing. I've tweaked the implementation a bunch to simply merge the labels upon fetching, which removes the need to do multiple checks later on. Thanks again for contributing!
To address this feature:
#452
Before:

After:

Sample
glance.yml
used during testing:Where an existing docker container with the name
glance
is running.