Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace outdated react-firebaseui package #694

Merged
merged 9 commits into from
Jan 23, 2024

Conversation

MvRemmerden
Copy link
Contributor

This replaces the outdated react-firebaseui package as mentioned in #555.

Copy link

vercel bot commented Dec 3, 2023

@MvRemmerden is attempting to deploy a commit to the Gladly Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Dec 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nfa-example ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 23, 2024 3:38pm

Copy link
Contributor

@kmjennison kmjennison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this contribution! It looks great. Just requesting a few quick edits.

example/components/StyledFirebaseAuth.tsx Show resolved Hide resolved
example/package-lock.json Outdated Show resolved Hide resolved
@MvRemmerden
Copy link
Contributor Author

Thank you for this contribution! It looks great. Just requesting a few quick edits.

Done, back to you 🙂

package.json Outdated Show resolved Hide resolved
Copy link
Contributor

@kmjennison kmjennison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just requesting another minor lint fix. Reminder that you can check linting yourself locally by running yarn lint at the package root. Thanks for these edits!

example/components/StyledFirebaseAuth.tsx Show resolved Hide resolved
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4556701) 98.08% compared to head (5009266) 98.08%.

Additional details and impacted files
@@           Coverage Diff           @@
##             v1.x     #694   +/-   ##
=======================================
  Coverage   98.08%   98.08%           
=======================================
  Files          31       31           
  Lines         888      888           
  Branches      270      270           
=======================================
  Hits          871      871           
  Misses         17       17           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kmjennison kmjennison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thank you for the contribution and revisions!

@kmjennison kmjennison merged commit 6f5b0c9 into gladly-team:v1.x Jan 23, 2024
4 checks passed
@MvRemmerden
Copy link
Contributor Author

Looks great. Thank you for the contribution and revisions!

No worries, thanks for the guidance! Very happy to have contributed at least something back to this project, which has been super helpful for me! 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants