Add support for @ prefix on MentionFilter base_url #411
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a situation where I wanted to use the
@
prefix on mention links with theMentionFilter
(the way tilde is already supported). Example:/@username
.Currently, if you set the
base_url
like this:base_url: "/@"
, then the link would be:/@/username
and I don't want the slash between @ and username.I've updated
MentionFilter#link_to_mentioned_user
andTeamMentionFilter#link_to_mentioned_team
to support this, and added accompanying tests.Additionally, I noticed that the regex
%r{[/~]\z}
will match strings like~~~
and////
and I'm wondering if that's intended? If not, I could change those checks to something likeurl.ends_with?("/@")
.Thanks for this gem! 😊