All of my changes #71
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
August 19, 2020 01:29
This produced a nonsensical warning in client mode. It is also redundant as there is this line: log_printf(L_INFO, "Server in ToxID whitelisting mode - only clients listed with -i can connect");
The client and server blocks were nearly identical. Now they share code. Both client and server now call memset() on tox_printable_id. The distinct client message "Generated Tox ID: %s\n" was not preserved; both client and server will say "Using Tox ID: %s\n" which is more accurate (Tox ID might be persistent with -C).
This relies on a patched c-toxcore. For that reason, it is disabled by an #ifdef.
Renamed some variables. Improved clarity of conditional.
The hostname "*" is treated as a wildcard. Port 0 is treated as a wildcard. Closes gjedeer#56
This reflects the fact that the rules constitute a whitelist.
The rules are reloaded as needed upon every connection.
The public keys of different toxid ssh servers were stored in known_hosts under the name 'localhost'. The key is stored under the toxid instead.
ROFL, warnings were disabled. also enabled -O2
the bug didn't matter
doing it eliminated some warnings
This reverts commit e247b29.
|
Kudos, SonarCloud Quality Gate passed!
|
|
Hey, Thank you for the PRs. They're so big they require a lot of time to review and merge. Some of the commits were OK, some I didn't want to merge, and it was too much time to cherry pick all of them - so I did not merge the PRs. I hope to eventually review your code but if you make future contributions, please please submit one functionality per PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm pushing the rest of my changes to
tuntoxthat I didn't push earlier when I wrote them, for whatever reasons. I think I didn't want to expose the LOG_IP_ADDRESS functionality since it requires my patches toc-toxcoreso I stopped making PRs after adding that feature. But it's disabled by#ifdefanyway. Most of this stuff is a few years old, but I made some commits today.I see that you've added some commits too and not merged my previous PRs. So maybe these further commits will never be merged. Either way I'm posting this just so you (and/or others) are aware of this development.
There is a new script
toxishthat editsssh_configso one can usetuntoxwith a simplesshcommand, and some improvements to the old scripts too. There are improvements and fixes to the build process. There are minor bug fixes, and lots of cleanups and simplifications.I see there are some mistakes and reverted commits that should be edited out/squashed with
rebase. Not really a clean PR here. I actually wouldn't mind cleaning it up or even would prefer to erase my mistakes before they are merged here, but that may be moot so I'm just sending it immediately.Once again, thanks for making
tuntox!