Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Harmless improvements #61

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Harmless improvements #61

wants to merge 15 commits into from

Commits on Aug 19, 2020

  1. also write tox_save in client mode (with -C)

    Andrew Cady committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    e6285bf View commit details
    Browse the repository at this point in the history

  2. Remove spurious debug output 

    This produced a nonsensical warning in client mode.

It is also redundant as there is this line:

log_printf(L_INFO, "Server in ToxID whitelisting mode - only clients listed with -i can connect");
    Andrew Cady committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    ee6e937 View commit details
    Browse the repository at this point in the history

  3. Avoid code repetition 

    The client and server blocks were nearly identical.  Now they share code.

Both client and server now call memset() on tox_printable_id.

The distinct client message "Generated Tox ID: %s\n" was not preserved;
both client and server will say "Using Tox ID: %s\n" which is more
accurate (Tox ID might be persistent with -C).
    Andrew Cady committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    15400c2 View commit details
    Browse the repository at this point in the history

  4. gitignore build products

    Andrew Cady committed Aug 19, 2020
    Configuration menu
    Copy the full SHA
    c72d709 View commit details
    Browse the repository at this point in the history

Commits on Aug 20, 2020

  1. remove unused variable

    Andrew Cady committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    de62d93 View commit details
    Browse the repository at this point in the history

  2. whitespace fixes

    Andrew Cady committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    5d1bce6 View commit details
    Browse the repository at this point in the history

  3. tokssh: persist client key if ~/.tuntox/persist/ exists

    Andrew Cady committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    d2345a8 View commit details
    Browse the repository at this point in the history

  4. improve parsing

    Andrew Cady committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    930eda7 View commit details
    Browse the repository at this point in the history

  5. ping mode: quit after pong (per documentation)

    Andrew Cady committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    8b340e2 View commit details
    Browse the repository at this point in the history

  6. remove unused variable

    Andrew Cady committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    9217b34 View commit details
    Browse the repository at this point in the history

  7. avoid redundant comparison

    Andrew Cady committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    6ce9e56 View commit details
    Browse the repository at this point in the history

  8. use tox_callback_friend_connection_status instead of polling

    Andrew Cady committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    ab4fa64 View commit details
    Browse the repository at this point in the history

  9. two new make targets: install-debs and debs

    Andrew Cady committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    8569e6c View commit details
    Browse the repository at this point in the history

  10. gitignore gitversion.h

    Andrew Cady committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    7712e55 View commit details
    Browse the repository at this point in the history

  11. add "-dirty" to gitversion.h when tree is dirty"

    Andrew Cady committed Aug 20, 2020
    Configuration menu
    Copy the full SHA
    ed93588 View commit details
    Browse the repository at this point in the history