Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an action list component #3786

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

nzaytsev
Copy link
Contributor

Description

Checklist

  • I have followed the guidelines in the Contributing document
  • My changes follow the coding style of this project
  • My changes build without any errors or warnings
  • My changes have been formatted and linted
  • My changes include any required corresponding changes to the documentation (including CHANGELOG.md and README.md)
  • My changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
  • My changes have a descriptive commit message with a short title, including a Fixes $XXX - or Closes #XXX - prefix to auto-close the issue that your PR addresses

@nzaytsev nzaytsev linked an issue Nov 21, 2024 that may be closed by this pull request
@nzaytsev nzaytsev requested review from d13 and eamodio November 21, 2024 10:04
@nzaytsev nzaytsev force-pushed the features/3785-add-an-action-list-component branch from e786635 to 10c5133 Compare November 22, 2024 01:41
@nzaytsev nzaytsev force-pushed the features/3785-add-an-action-list-component branch from b29ec70 to 6283612 Compare November 22, 2024 09:43
@nzaytsev nzaytsev marked this pull request as ready for review November 22, 2024 09:43
@d13
Copy link
Member

d13 commented Nov 22, 2024

Hey @nzaytsev, while reviewing your PR, I'd suggest the following code changes:

👉 Update the SetTimeout

You can also review and apply these suggestions locally on your machine.

Learn more about GitKraken Code Suggest

Code Suggest liberates your code reviews from GitHub's restrictive, comment-only feedback style. As simple as suggesting changes in a Google-doc, provide real code suggestions from where you code, e.g. your IDE, and on anything in your project — not just on the lines of code changed in the PR.

Join your team on GitKraken to speed up PR review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an action-list component
2 participants