Adds Open tag on remote option to tagView #3768
Conversation
package.json
Outdated
| @@ -3668,7 +3668,8 @@ | |||
| "fileInCommit", | |||
| "fileInBranch", | |||
| "fileLine", | |||
| "fileRange" | |||
| "fileRange", | |||
| "tagName" | |||
There was a problem hiding this comment.
Rename to tag to match branch, commit, etc
package.json
Outdated
| @@ -3706,6 +3707,10 @@ | |||
| "fileRange": { | |||
| "type": "string", | |||
| "markdownDescription": "Specifies the format of a range in a file URL for the custom remote service\n\nAvailable tokens\\\n`${start}` — starting line\\\n`${end}` — ending line" | |||
| }, | |||
| "tagName": { | |||
package.json
Outdated
| @@ -6752,6 +6757,12 @@ | |||
| "title": "Open Commit on Remote", | |||
| "icon": "$(globe)" | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
Add a gitlens.openTagOnRemote command like commit/branch/etc for access from the Command Palette
There was a problem hiding this comment.
Should also not be placed in the middle of the commit commands, put it after
| "command": "gitlens.views.openTagOnRemote", | ||
| "when": "gitlens:repos:withRemotes && viewItem =~ /gitlens:tag\\b(.*?\\b\\+remote\\b)/", | ||
| "group": "inline@99" | ||
| }, |
There was a problem hiding this comment.
Add a gitlens.views.copyRemoteTagUrl command and add it as an alt, like commit
There was a problem hiding this comment.
Needs to also follow the commit[s] pattern to add this to the context menu as well
| @@ -580,6 +580,7 @@ export interface RemotesUrlsConfig { | |||
| readonly fileInCommit: string; | |||
| readonly fileLine: string; | |||
| readonly fileRange: string; | |||
| readonly tag: string; | |||
There was a problem hiding this comment.
This is correct once tagName is renamed above
src/git/remotes/custom.ts
Outdated
| @@ -100,6 +100,10 @@ export class CustomRemote extends RemoteProvider { | |||
| return url; | |||
| } | |||
|
|
|||
| protected override getUrlForTag(tagName: string): string { | |||
| return this.getUrl(this.urls.tag, this.getContext({ tagName: tagName })); | |||
| @@ -191,4 +191,8 @@ export class GerritRemote extends RemoteProvider { | |||
| if (branch) return `${this.encodeUrl(`${this.getUrlForBranch(branch)}/${fileName}`)}${line}`; | |||
| return `${this.encodeUrl(`${this.baseUrl}/+/HEAD/${fileName}`)}${line}`; | |||
| } | |||
|
|
|||
| protected override getUrlForTag(): string | undefined { | |||
| return undefined; | |||
There was a problem hiding this comment.
There is no tag details view for gerrit, only tags list view
src/views/nodes/tagsNode.ts
Outdated
| @@ -33,13 +34,20 @@ export class TagsNode extends CacheableChildrenViewNode<'tags', ViewsWithTagsNod | |||
| } | |||
|
|
|||
| async getChildren(): Promise<ViewNode[]> { | |||
| const remote = await this.repo.git.getBestRemoteWithProvider(); | |||
There was a problem hiding this comment.
Why is this outside the if below?
| "title": "Open Tag on Remote", | ||
| "category": "GitLens", | ||
| "icon": "$(globe)" | ||
| }, |
There was a problem hiding this comment.
Should also add gitlens.views.openTagOnRemote.multi command to follow the pattern of commit[s]
Description
Checklist
Fixes $XXX -orCloses #XXX -prefix to auto-close the issue that your PR addresses