3533 Change reset terminal-run commands into normal commands w/ proper error handling
#3676
+134
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiolms
force-pushed
the
feature/#3533_change_git_reset_cmds_from_terminal_to_normal_cmds
branch
from
e6953f6
to
94bda2c
Compare
axosoft-ramint
approved these changes
Oct 24, 2024
sergiolms
force-pushed
the
feature/#3533_change_git_reset_cmds_from_terminal_to_normal_cmds
branch
2 times, most recently
from
3adc472
to
1a652e4
Compare
axosoft-ramint
requested changes
Nov 7, 2024
|
@sergiolms I went ahead and fixed the ☝🏼 error |
axosoft-ramint
approved these changes
Nov 7, 2024
There was a problem hiding this comment.
I couldn't reproduce any of the error types here, but I don't have further time to test. @eamodio feel free to give this a test run, otherwise LGTM
sergiolms
force-pushed
the
feature/#3533_change_git_reset_cmds_from_terminal_to_normal_cmds
branch
from
1187eac
to
cbef015
Compare
sergiolms
force-pushed
the
feature/#3533_change_git_reset_cmds_from_terminal_to_normal_cmds
branch
from
cbef015
to
e6634de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This task creates the
git resetcommands to move away fromrunTerminalCommand. Solves #3533To be defined:
Checklist
Fixes $XXX -orCloses #XXX -prefix to auto-close the issue that your PR addresses