Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored spaghetti code: Turned the mess into lasagna, layers and all. #228

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vicenter-gitkraken
Copy link
Contributor

This PR tackles the infamous spaghetti code issue we've all been struggling with, transforming it into a well-layered, maintainable structure that’s as satisfying as a good lasagna. Each layer is organized, readable, and built with a clear separation of concerns in mind.

@vicenter-gitkraken vicenter-gitkraken added the enhancement New feature or request label Aug 29, 2024
@jjsilva4 jjsilva4 added this to the 10.5 release milestone Sep 26, 2024
@jkelroy jkelroy self-requested a review October 3, 2024 04:10
@vicenter-gitkraken
Copy link
Contributor Author

Hey @vicenter-gitkraken, while reviewing your PR, I'd suggest the following code changes:

👉 Code Suggestion for #228

#228

You can also review and apply these suggestions locally on your machine.

Learn more about GitKraken Code Suggest

Code Suggest liberates your code reviews from GitHub's restrictive, comment-only feedback style. As simple as suggesting changes in a Google-doc, provide real code suggestions from where you code, e.g. your IDE, and on anything in your project — not just on the lines of code changed in the PR.

Join your team on GitKraken to speed up PR review.

@jkelroy
Copy link
Contributor

jkelroy commented Nov 14, 2024

Hey @vicenter-gitkraken, while reviewing your PR, I'd suggest the following code changes:

👉 Code Suggestion for #228

#228

You can also review and apply these suggestions locally on your machine.

Learn more about GitKraken Code Suggest

Code Suggest liberates your code reviews from GitHub's restrictive, comment-only feedback style. As simple as suggesting changes in a Google-doc, provide real code suggestions from where you code, e.g. your IDE, and on anything in your project — not just on the lines of code changed in the PR.

Join your team on GitKraken to speed up PR review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants