Consume new rich test events in new Test Explorer UI #2394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbartol
changed the title
dbartol
added
the
Complexity: Medium
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the new test UI to consume the richer events emitted by
codeql test runstarting in CLI 2.13.1. We now get a notification when a test starts executing, so we can update the Test Explorer with the right spinning icon.I had to do a little work in the CLI server client code to handle multiple streaming output formats.
I refactored some of the tracking of which tests are in which directory into a new
TestRunContextclass.The legacy test adapter code has been updated to consume the new format for the existing
TestCompletedevent, but has not been updated to consume the new events.