Skip to content

Commit

Permalink
Revert "add logs"
Browse files Browse the repository at this point in the history
This reverts commit 0aff7e0.
  • Loading branch information
mhamza15 committed Jan 28, 2025
1 parent 2374d14 commit 2bbfb11
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 14 deletions.
10 changes: 1 addition & 9 deletions go/pools/smartconnpool/pool.go
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ import (
"sync/atomic"
"time"

"github.com/davecgh/go-spew/spew"
"vitess.io/vitess/go/hack"
"vitess.io/vitess/go/vt/log"
vtrpcpb "vitess.io/vitess/go/vt/proto/vtrpc"
Expand Down Expand Up @@ -510,17 +509,10 @@ func (pool *ConnPool[C]) get(ctx context.Context) (*Pooled[C], error) {
// to other clients, wait until one of the connections is returned
if conn == nil {
start := time.Now()

oldPool := spew.Sdump(pool)

conn, err = pool.wait.waitForConn(ctx, nil)
if err != nil {

log.Errorf("===================== ERROR: waitForConn err: %s", err.Error())
log.Errorf("Old pool")
log.Errorf(oldPool)
log.Errorf("New pool")
log.Errorf(spew.Sdump(pool))
log.Errorf("%+v", pool)
return nil, ErrTimeout
}
pool.recordWait(start)
Expand Down
5 changes: 0 additions & 5 deletions go/pools/smartconnpool/waitlist.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,9 @@ package smartconnpool

import (
"context"
"runtime/debug"
"sync"

"vitess.io/vitess/go/list"
"vitess.io/vitess/go/vt/log"
)

// waiter represents a client waiting for a connection in the waitlist
Expand Down Expand Up @@ -73,9 +71,6 @@ func (wl *waitlist[C]) waitForConn(ctx context.Context, setting *Setting) (*Pool
if conn != nil {
return conn, nil
}

log.Errorf("======================== STACK TRACE")
debug.PrintStack()
return nil, ctx.Err()
}

Expand Down

0 comments on commit 2bbfb11

Please sign in to comment.