Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add black linter to make lint #102

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

jmeridth
Copy link
Member

@jmeridth jmeridth commented Mar 15, 2024

Pull Request

Proposed Changes

Since super-linter isn't arm64 friendly yet (what we use for linting in GitHub Actions on this repo), I'm a fan of adding black linter to make lint.

✗ make lint
pylint --rcfile=.pylintrc --fail-under=9.0 *.py

--------------------------------------------------------------------
Your code has been rated at 10.00/10 (previous run: 10.00/10, +0.00)

# stop the build if there are Python syntax errors or undefined names
flake8 . --count --select=E9,F63,F7,F82 --exclude .venv --show-source --statistics
0
# exit-zero treats all errors as warnings. The GitHub editor is 127 chars wide
flake8 . --count --exclude .venv --exit-zero --max-complexity=10 --max-line-length=127 --statistics
0
black .
All done! ✨ 🍰 ✨

Readiness Checklist

Author/Contributor

  • If documentation is needed for this change, has that been included in this pull request
  • run make lint and fix any issues that you have introduced
  • run make test and ensure you have test coverage for the lines you are introducing

Reviewer

  • Label as either bug, documentation, enhancement, infrastructure, or breaking

Since super-linter isn't arm64 friendly yet, I'm a fan of
adding black linter to `make lint`.

Signed-off-by: jmeridth <[email protected]>
@jmeridth jmeridth requested a review from zkoppert as a code owner March 15, 2024 16:37
@zkoppert zkoppert added the infrastructure tests or other arch things label Mar 15, 2024
Copy link
Member

@zkoppert zkoppert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@zkoppert zkoppert merged commit 86b2df9 into github:main Mar 15, 2024
7 checks passed
@jmeridth jmeridth deleted the jm-add-black-linter-to-make-lint branch March 16, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure tests or other arch things
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants