Skip to content
This repository has been archived by the owner on Oct 8, 2024. It is now read-only.

Allow user to set calls per minute in the RateLimiter #127

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ctoestreich
Copy link

Allow user to provide a param callsPerMinute via configuration block to allow more calls per minute to github. Without param default is 20. This will address some issues from #90 #17 #28 #88 @jakeswenson @alem0lars @bguerin @kevinsawicki

User can configure the following

            <plugin>
                <groupId>com.github.github</groupId>
                <artifactId>site-maven-plugin</artifactId>
                <version>0.13-SNAPSHOT</version>
                <configuration>
                    <callsPerMinute>1000</callsPerMinute>
                </configuration>
            </plugin>

… allow faster git stuff to GHE or non-public githubs
… allow faster git stuff to GHE or non-public githubs
Copy link
Contributor

@bguerin bguerin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you can avoid gratuitous formating which make the PR hard to read.
Otherwise, great !

@ctoestreich
Copy link
Author

I tried to unwind all the tab v spaces that I would but there is no code style profile in the project and some of the formatting is a bit unclear like 1 space + 1 Tab for indents in java files. I had a hard time reproducing that format with my current style settings in IntelliJ. :)

@bguerin
Copy link
Contributor

bguerin commented May 21, 2017

I understand. On projects like this (without formatting settings shared), I just does not automatically format sources with my IDE.

@ctoestreich
Copy link
Author

@bguerin Just checking on this as we near the 1yr mark.

@bguerin
Copy link
Contributor

bguerin commented May 8, 2018

And ? I am not a maintainer of these plugins, I only contributed to them ...
I do not have rights to merge ...

@ctoestreich
Copy link
Author

Who is a maintainer?

@ctoestreich
Copy link
Author

@kevinsawicki

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants