Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Go.gitignore -> Added .env #4428

Merged
merged 2 commits into from
May 29, 2024
Merged

Conversation

LombardiDaniel
Copy link
Contributor

Reasons for making this change:

I use the default Go gitignore and it should have .env in it by default

TODO

Links to documentation supporting these rule changes:

TODO

If this is a new template:

  • Link to application or project’s homepage: TODO

Copy link

@philfreshman philfreshman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@wirecat wirecat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please provide a bit more context around why you believe this should be added?

Also, we currently have some merge conflicts that will need resolved.

@LombardiDaniel
Copy link
Contributor Author

@wirecat resolved! The main reason for this change is just that so many apps do need some sort of .env file to keep secrets while on development, me and a couple of colleagues have accidently uploaded our .env files with API keys to git in go projects because we did not check the .gitignore (just assumed that .env was in there, as is the case with lots of other default .gitignores files)

Copy link
Collaborator

@wirecat wirecat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LombardiDaniel Thank you for resolving the merge conflict and adding clarification!

@wirecat wirecat merged commit fa2a447 into github:main May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants