Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Move language #4408

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Adds Move language #4408

wants to merge 1 commit into from

Conversation

gregnazario
Copy link

Reasons for making this change:
I am a core contributor to the Aptos blockchain https://github.com/aptos-labs/aptos-core, and I've written enough Move contracts to be inconvenienced / copy the same .gitignore between each. Trying to make it as simple as possible for onboarding.

Move language is used for MoveVM based blockchains as the language native to them. The compiler provides a folder build/ that holds the build artifacts.

The .aptos/ folder is ignored so people do not upload their private keys to a git repository.

Links to documentation supporting these rule changes:
Here's the Move book, though, it looks like it doesn't explicitly say that this comes from the compiler.

Example:

$ ls
Move.toml sources
$ aptos move compile --dev
Compiling, may take a little while to download git dependencies...
UPDATING GIT DEPENDENCY https://github.com/aptos-labs/aptos-core.git
INCLUDING DEPENDENCY AptosFramework
INCLUDING DEPENDENCY AptosStdlib
INCLUDING DEPENDENCY MoveStdlib
BUILDING Coin
{
  "Result": [
    "0000000000000000000000000000000000000000000000000000000000111111::coin"
  ]
}
$ ls
Move.toml build     sources

This applies to all blockchains that use the Move compiler.

Additionally, for Aptos specifically the Aptos CLI adds an account it'll create a file structure like below where the config.yaml has credentials in it:

$ ls -a
.          ..         .aptos     .gitignore Move.toml  build      sources
$ ls .aptos
config.yaml

It's best that all Move blockchains add anything here that may add unwanted credentials associated with their blockchains.

If this is a new template:

Move language is used for MoveVM based blockchains as the language
native to them.  The compiler provides a folder build/ that holds
the build artifacts.

The .aptos/ folder is ignored so people do not upload their private
keys to a git repository.
@gregnazario
Copy link
Author

@martinwoodward, what do we have to do to get these merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant