Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenID Connection configuration for Alibaba Cloud #29916

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JacksonTian
Copy link

Why:

Closes:

What's being changed (if available, include any code snippets, screenshots, or gifs):

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline.

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • For content changes, I have completed the self-review checklist.

Copy link

welcome bot commented Nov 13, 2023

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Nov 13, 2023
Copy link
Contributor

👋 Hey there spelunker. It looks like you've modified some files that we can't accept as contributions. The complete list of files we can't accept are:
.devcontainer/**
.github/workflows/**
.github/CODEOWNERS
assets/fonts/**
data/graphql/**
Dockerfile*
src//scripts/**
src/.json
src/workflows/

lib/redirects/**
package
.json
content/actions/deployment/security-hardening-your-deployments/**

You'll need to revert all of the files you changed in that list using GitHub Desktop or git checkout origin/main <file name>. Once you get those files reverted, we can continue with the review process. :octocat:

Copy link
Contributor

github-actions bot commented Nov 13, 2023

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.


Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
New file: actions/deployment/security-hardening-your-deployments/configuring-openid-connect-in-alibaba-cloud.md fpt
ghec
ghes@ 3.11 3.10 3.9 3.8 3.7
fpt
ghec
ghes@ 3.11 3.10 3.9 3.8 3.7
actions/deployment/security-hardening-your-deployments/index.md fpt
ghec
ghes@ 3.11 3.10 3.9 3.8 3.7
fpt
ghec
ghes@ 3.11 3.10 3.9 3.8 3.7

fpt: Free, Pro, Team
ghec: GitHub Enterprise Cloud
ghes: GitHub Enterprise Server
ghae: GitHub AE

@JacksonTian
Copy link
Author

Why can't contribute the content/actions/deployment/security-hardening-your-deployments/**.

@JacksonTian
Copy link
Author

Hope someone can help me.

@cmwilson21
Copy link
Contributor

@JacksonTian Thanks for your interest in contributing to the Docs and for submitting a PR! ✨

We have built in security checks for any changes made to potentially sensitive files, like the security hardening files you are attempting to change in this PR. They will require an extra review before being considered for acceptance.

For future reference, in cases like this where you are adding a new article or guide, we encourage you to open an issue first. That way, we can review the need for your proposed addition before you submit your PR. That will greatly improve the review experience for both sides of the PR. 👍

I'll run this by our team and get it up for review 👀

@JacksonTian
Copy link
Author

@cmwilson21 Thank you for your feedback.

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team actions This issue or pull request should be reviewed by the docs actions team waiting for review Issue/PR is waiting for a writer's review needs SME This proposal needs review from a subject matter expert and removed triage Do not begin working on this issue until triaged by the team labels Nov 14, 2023
Copy link
Contributor

Thanks for opening a pull request! We've triaged this issue for technical review by a subject matter expert 👀

@JacksonTian
Copy link
Author

Hello, any feedbacks?

Copy link
Contributor

This is a gentle bump for the docs team that this PR is waiting for technical review.

@github-actions github-actions bot added the SME stale The request for an SME has staled label Feb 14, 2024
@SiaraMist
Copy link
Contributor

Hey @JacksonTian, thank you so much for writing this article and opening an PR to add it to our docs! ✨

Do you know if there is any Alibaba doc that can be cross referenced for GitHub OIDC integration? After checking with our engineering team, we are hoping to use this to internally verify an Alibaba set up.

@JacksonTian
Copy link
Author

JacksonTian commented Feb 21, 2024

Hello @SiaraMist . The article https://www.alibabacloud.com/help/en/ram/user-guide/overview-of-oidc-based-sso describes how to use OIDC on Alibaba Cloud.

And we have a GitHub Action https://github.com/aliyun/configure-aliyun-credentials-action to integrate with GitHub OIDC.

Thanks for your feedback.

@github-actions github-actions bot removed the SME stale The request for an SME has staled label Feb 21, 2024
Copy link
Contributor

This is a gentle bump for the docs team that this PR is waiting for technical review.

@github-actions github-actions bot added the SME stale The request for an SME has staled label Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actions This issue or pull request should be reviewed by the docs actions team content This issue or pull request belongs to the Docs Content team needs SME This proposal needs review from a subject matter expert SME stale The request for an SME has staled waiting for review Issue/PR is waiting for a writer's review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants