Brodes/seh flow phase2 splitting seh edges #18049
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…EH is not yet part of the IR generation to make this logic work.
…rowException as well.
…ub.com/microsoft/codeql into brodes/seh_flow_phase1_throwing_models
…ds compatibility.
…ub.com/microsoft/codeql into brodes/seh_flow_phase1_throwing_models
…ption to be consistent with other backward compatibility changes.
Co-authored-by: Mathias Vorreiter Pedersen <[email protected]>
…ot apply the edges yet, just stipulates the types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Phase 2 SEH handling PR. This phase simply establishes there are two edge types. Where a specific edge must be chosen, we assume it is a C++ edge. The next phase PR will fully establish uses of these edge types to correctly distinguish SEH from ordinary C++ exception edges.