Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go: Fix missing promoted fields due to name clash #18001

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Go: Fix missing promoted fields due to name clash #18001

wants to merge 5 commits into from
+198 −134

Commits on Nov 22, 2024

  1. Add test showing promoted field bug 

    NCField should be promoted to EmbedsNameClash. Currently it isn't
because its embedded parent pkg2.NameClash is not a promoted field in
EmbedsNameClash (because of a name clash with pkg1.NameClash), but this
should not make a difference.
    @owen-mc
    owen-mc committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    a8ccb81 View commit details
    Browse the repository at this point in the history

  2. Fix bug

    @owen-mc
    owen-mc committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    9bbc9c7 View commit details
    Browse the repository at this point in the history

  3. Refactor struct field predicate to remove redundancy

    @owen-mc
    owen-mc committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    7d4f2ad View commit details
    Browse the repository at this point in the history

  4. Add change note

    @owen-mc
    owen-mc committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    981948f View commit details
    Browse the repository at this point in the history

  5. Small stylistic improvement

    @owen-mc
    owen-mc committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    4a05c3d View commit details
    Browse the repository at this point in the history