All: delete outdated deprecations

[erik-krogh]

Similar to last time: #15393

Not that much this time.

[aschackmull]

Java 👍
I love that you keep doing these! Have you got the process fully automated by now?

[erik-krogh]

Java 👍 I love that you keep doing these! Have you got the process fully automated by now?

The initial deletion of the predicates has been automated the entire time.
But I still need to look through the changes and delete any excess dead code, and then make sure everything still works.
And the change-note is still manual.

[alexrford]

Ruby 👍

[tausbn]

Python 👍

[atorralba]

Shouldn't this be breaking?

[atorralba]

Probably this has been discussed in the past, sorry if that's the case.

[erik-krogh]

It is technically a breaking change to delete code. However, it's code that has been deprecated for more than a year, so external users have had plenty of to migrate.

So I still think it's a minor change.

I couldn't find a discussion in the past about this.
But all previous change-notes when deleting deprecations have been minorAnalysis. (Since the first deprecation deletion PR).

[MathiasVP]

I don't think the amount of time the thing has been deprecated should influence whether or not this is a breaking change. A breaking change is a breaking change.

Obviously, this breaking change is totally justified, but I still think stuff like this should be marked as a breaking change going forward

[erik-krogh]

👍

I've changed it to breaking.
I usually look at the previous PR when making the next one, so I should mark these as breaking in the future.

[jketema]

C++ 👍

[hvitved]

C# 👍

[mbg]

Go 👍🏻