New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[8th May 2024] Add deprecation notices to CodeQL for VS Code documentation #16320
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes in the go/
directory look fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quite a few comments, but most are to link people to Installing CodeQL for Visual Studio Code - GitHub Docs when we tell them to set up the extension, rather than the generic article.
Co-authored-by: Ben Ahmady <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Python changes LGTM. 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a couple of small fixes, but this looks ready to merge.
@jf205 👋 Could you please have another look at this one? It looks like after you're OK with it, we should be set to merge tomorrow 😄 |
Co-authored-by: James Fletcher <[email protected]>
Thanks @jf205 @felicitymay if one of you could kindly reapprove, I'll aim to have this merged in sync with the redirects tomorrow |
Just to note that @saritai will be keeping an eye out for the redirects PR to ship today, and then she'll merge this PR. The person merging the redirects PR is on Pacific Time and Sarita's on Eastern Time, so it will likely happen in the evening during British Summer Time. cc @jf205 |
On the 8th May, we're set to start automatically redirecting users from pages under https://codeql.github.com/docs/codeql-for-visual-studio-code/ to https://docs.github.com/en/code-security/codeql-for-vs-code/
This PR adds a deprecation note (reusable) to each of the pages under https://codeql.github.com/docs/codeql-for-visual-studio-code/, for those users whose browsers don't redirect. It also updates other instances of soon-to-be-outdated links in this repo, and adds a note to
CONTRIBUTING.md
about how to contribute to the newly migrated docs.