Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8th May 2024] Add deprecation notices to CodeQL for VS Code documentation #16320

Merged
merged 7 commits into from May 8, 2024

Conversation

subatoi
Copy link
Contributor

@subatoi subatoi commented Apr 25, 2024

On the 8th May, we're set to start automatically redirecting users from pages under https://codeql.github.com/docs/codeql-for-visual-studio-code/ to https://docs.github.com/en/code-security/codeql-for-vs-code/

This PR adds a deprecation note (reusable) to each of the pages under https://codeql.github.com/docs/codeql-for-visual-studio-code/, for those users whose browsers don't redirect. It also updates other instances of soon-to-be-outdated links in this repo, and adds a note to CONTRIBUTING.md about how to contribute to the newly migrated docs.

@subatoi subatoi added the ready-for-doc-review This PR requires and is ready for review from the GitHub docs team. label Apr 25, 2024
@subatoi subatoi marked this pull request as ready for review April 25, 2024 17:39
@subatoi subatoi requested review from a team as code owners April 25, 2024 17:39
@subatoi subatoi requested a review from jf205 April 26, 2024 06:51
mbg
mbg previously approved these changes May 1, 2024
Copy link
Member

@mbg mbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in the go/ directory look fine.

felicitymay
felicitymay previously approved these changes May 2, 2024
Copy link
Contributor

@felicitymay felicitymay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite a few comments, but most are to link people to Installing CodeQL for Visual Studio Code - GitHub Docs when we tell them to set up the extension, rather than the generic article.

README.md Outdated Show resolved Hide resolved
docs/codeql/ql-training/cpp/bad-overflow-guard.rst Outdated Show resolved Hide resolved
docs/codeql/ql-training/cpp/control-flow-cpp.rst Outdated Show resolved Hide resolved
docs/codeql/ql-training/cpp/data-flow-cpp.rst Outdated Show resolved Hide resolved
docs/codeql/ql-training/cpp/global-data-flow-cpp.rst Outdated Show resolved Hide resolved
docs/codeql/ql-training/java/global-data-flow-java.rst Outdated Show resolved Hide resolved
docs/codeql/ql-training/java/intro-ql-java.rst Outdated Show resolved Hide resolved
docs/codeql/ql-training/java/query-injection-java.rst Outdated Show resolved Hide resolved
docs/codeql/ql-training/template.rst Outdated Show resolved Hide resolved
python/ql/src/CHANGELOG.md Outdated Show resolved Hide resolved
@felicitymay felicitymay dismissed stale reviews from mbg and themself via 6eb07a7 May 2, 2024 10:05
tausbn
tausbn previously approved these changes May 2, 2024
Copy link
Contributor

@tausbn tausbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python changes LGTM. 👍

felicitymay
felicitymay previously approved these changes May 2, 2024
Copy link
Contributor

@felicitymay felicitymay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a couple of small fixes, but this looks ready to merge.

@subatoi subatoi requested a review from jf205 May 7, 2024 07:41
@subatoi
Copy link
Contributor Author

subatoi commented May 7, 2024

@jf205 👋 Could you please have another look at this one? It looks like after you're OK with it, we should be set to merge tomorrow 😄

jf205
jf205 previously approved these changes May 7, 2024
README.md Outdated Show resolved Hide resolved
Co-authored-by: James Fletcher <[email protected]>
@subatoi
Copy link
Contributor Author

subatoi commented May 7, 2024

Thanks @jf205 @felicitymay if one of you could kindly reapprove, I'll aim to have this merged in sync with the redirects tomorrow

@subatoi
Copy link
Contributor Author

subatoi commented May 8, 2024

Just to note that @saritai will be keeping an eye out for the redirects PR to ship today, and then she'll merge this PR. The person merging the redirects PR is on Pacific Time and Sarita's on Eastern Time, so it will likely happen in the evening during British Summer Time.

cc @jf205

@saritai saritai merged commit aab5da0 into main May 8, 2024
17 checks passed
@saritai saritai deleted the subatoi/deprecate-codeql-for-vs-code branch May 8, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Go Python ready-for-doc-review This PR requires and is ready for review from the GitHub docs team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants