Python: Model the Pyramid framework #16300
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
|
|
||
| abstract class ViewCallable extends PotentialViewCallable, Http::Server::RequestHandler::Range { | ||
| override Parameter getARoutedParameter() { result = this.getRequestParameter() } |
There was a problem hiding this comment.
for a route like /hello/<name> that is handled by def handle_hello(request, name): ... the <name> is a routed parameter. I haven't looked at the pyramid docs whether this is something they do, but that's sort of what it's for.
There was a problem hiding this comment.
I don't think pyramid has parameters like that (instead name would be in a matchdict object on the request.
Should the request parameter be modeled as a remote flow source separately from this then?
There was a problem hiding this comment.
Should the request parameter be modeled as a remote flow source separately from this then?
Yes please 👍
| private class PotentialViewCallable extends Function { | ||
| PotentialViewCallable() { | ||
| this.getPositionalParameterCount() = 1 and | ||
| this.getArgName(0) = "request" |
There was a problem hiding this comment.
is there a hard requirement that the request parameter MUST be called request? or could it be named req as well?
There was a problem hiding this comment.
Documentation suggests that it should:
View callables must, at a minimum, accept a single argument named request.
however empirical testing seems to show it can allow other names.
There was a problem hiding this comment.
Ah, let's include that in our tests, and let's change our modeling to handle that 👍
joefarebrother
force-pushed
the
python-pyramid
branch
from
ea09926
to
c6372d5
Compare
joefarebrother
changed the title
Adds models for the Pyramid framework - models view callables,
RequestandResponseobjects, and http redirects