Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔗 Fix broken URL for Codespace Create button #47

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

AnthonyByansi
Copy link

This PR fixes the broken URL for the Codespace Creation as observed;
image

@AnthonyByansi
Copy link
Author

Hi @alfredodeza, @burkeholland could you please have this fixed? Thanks!

@AnthonyByansi
Copy link
Author

Hi @saragibby
Could you please review this PR? Thank you!

README.md Outdated
@@ -85,7 +85,8 @@ To run what's in this repository, you need to first start a Codespaces instance.
1. Navigate to the main page of the newly created repository.
1. Under the repository name, use the Code drop-down menu, and in the Codespaces tab, select "Create codespace on main".

<img src="https://docs.github.com/assets/cb-138303/images/help/codespaces/new-codespace-button.png" alt="Create Codespace" style="width: 270px;"/>
<img src="https://github.com/user-attachments/assets/13f0af8d-7fe0-4a1e-a559-244db79c78cd" alt="Create Codespace" style="width: 600px;" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where is this user attachment coming from?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @alfredodeza
The file is uploaded to GitHub's storage and linked to the PR for reference,

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is the attachment that was uploaded to GitHub storage
create codespace

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, since this is going to a user storage, then the account can be removed/changed or the file simply deleted. Although your change would help address this, it is not a long-term solution which would be preferable

@AnthonyByansi
Copy link
Author

Hi @alfredodeza
The change has been Implemented through 7adc61a

@alfredodeza
Copy link
Contributor

@AnthonyByansi what I meant is that the image shouldn't come from a user account that uploaded it. In this case, the correct svg should be this one: https://github.com/codespaces/badge.svg

Can you make that change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants