Add roster identifier to assignment repos endpoint

app/controllers/api/assignment_repos_controller.rb

@@ -9,7 +9,7 @@ class AssignmentReposController < API::ApplicationController
 
  def index
  repos = AssignmentRepo.where(assignment: @assignment).order(:id)
- paginate json: repos
+ paginate json: repos, roster_entries: @organization.roster&.roster_entries
  end
 
  def clone_url

app/serializers/assignment_repo_serializer.rb

@@ -4,6 +4,7 @@ class AssignmentRepoSerializer < ActiveModel::Serializer
  attributes :id
  attributes :username
  attributes :displayName
+ attributes :rosterIdentifier
 
  def username
  object.user.github_user.login
@@ -13,5 +14,12 @@ def username
  def displayName
  object.user.github_user.name || ""
  end
+
+ def rosterIdentifier
+ return nil if instance_options[:roster_entries].blank?
+
+ roster_entry = instance_options[:roster_entries].find { |entry| entry.user_id == object.user.id }
+ roster_entry&.identifier
+ end
  # rubocop:enable MethodName
 end

spec/controllers/api/assignment_repos_controller_spec.rb

@@ -5,34 +5,76 @@
 RSpec.describe API::AssignmentReposController, type: :controller do
  let(:organization) { classroom_org }
  let(:user) { classroom_teacher }
+ let(:second_user) { classroom_student }
  let(:assignment) { create(:assignment, organization: organization, title: "Learn Clojure") }
 
  describe "GET #index", :vcr do
- before do
- @assignment_repo = create(:assignment_repo, assignment: assignment, github_repo_id: 42, user: user)
+ context "with a roster" do
+ before do
+ create(:assignment_repo, assignment: assignment, github_repo_id: 42, user: user)
+ create(:assignment_repo, assignment: assignment, github_repo_id: 43, user: second_user)
 
- get :index, params: {
- organization_id: organization.slug,
- assignment_id: assignment.slug,
- access_token: user.api_token
- }
- end
+ roster = create(:roster)
+ @entry = create(:roster_entry, roster: roster, identifier: "entryA", user: user)
 
- after do
- AssignmentRepo.destroy_all
- end
+ organization.roster = roster
+ organization.save
 
- it "returns success" do
- expect(response).to have_http_status(200)
- end
+ get :index, params: {
+ organization_id: organization.slug,
+ assignment_id: assignment.slug,
+ access_token: user.api_token
+ }
+ end
+
+ after do
+ AssignmentRepo.destroy_all
+ end
+
+ it "returns success" do
+ expect(response).to have_http_status(200)
+ end
 
- it "returns all of the assignment repos" do
- expect(json.length).to eql(1)
+ it "returns all of the assignment repos" do
+ expect(json.length).to eql(2)
+ end
+
+ it "returns correct attributes in assignment repo serializer" do
+ expect(json.first["username"]).to eq(user.github_user.login)
+ expect(json.first["displayName"]).to eq(user.github_user.name)
+ expect(json.first["rosterIdentifier"]).to eq(@entry.identifier)
+ end
  end
 
- it "returns correct attributes in assignment repo serializer" do
- expect(json.first["username"]).to eq(user.github_user.login)
- expect(json.first["displayName"]).to eq(user.github_user.name)
+ context "without a roster" do
+ before do
+ create(:assignment_repo, assignment: assignment, github_repo_id: 42, user: user)
+ create(:assignment_repo, assignment: assignment, github_repo_id: 43, user: second_user)
+
+ get :index, params: {
+ organization_id: organization.slug,
+ assignment_id: assignment.slug,
+ access_token: user.api_token
+ }
+ end
+
+ after do
+ AssignmentRepo.destroy_all
+ end
+
+ it "returns success" do
+ expect(response).to have_http_status(200)
+ end
+
+ it "returns all of the assignment repos" do
+ expect(json.length).to eql(2)
+ end
+
+ it "returns correct attributes in assignment repo serializer" do
+ expect(json.first["username"]).to eq(user.github_user.login)
+ expect(json.first["displayName"]).to eq(user.github_user.name)
+ expect(json.first["rosterIdentifier"]).to be_nil
+ end
  end
  end