This repository has been archived by the owner on Jun 24, 2024. It is now read-only.
Implement ActionCable #1442
Merged
Implement ActionCable #1442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d12
reviewed
Jul 30, 2018
| @@ -158,14 +158,6 @@ | |||
| location.href = success_path(); | |||
| }; | |||
|
|
|||
| check_progress = function() { | |||
There was a problem hiding this comment.
Why don't we need this anymore?
There was a problem hiding this comment.
check_progress would make a GET request to get the progress of the of the ongoing create and import. It would make this request continuously.
Instead of polling for the progress we are receiving the progress with ActionCable.
d12
approved these changes
Jul 30, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR implements ActionCable on client side in place of short polling. The backend ActionCable message broadcasting is already complete.
This closes #1395