meson: wire up contrib/credential #1859
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix an error when compiling with MSVC. Signed-off-by: M Hickford <[email protected]>
Signed-off-by: M Hickford <[email protected]>
hickford
force-pushed
the
meson-credential
branch
from
31d8640 to
07ce068
Compare
|
/submit |
|
Submitted as [email protected] To fetch this version into To fetch this version to local tag |
|
This patch series was integrated into seen via git@16c9bca. |
|
On the Git mailing list, Patrick Steinhardt wrote (reply to this): On Thu, Feb 13, 2025 at 06:37:37PM +0000, M Hickford via GitGitGadget wrote:
> It would be neat to also run test t0303-credential-external with
> GIT_TEST_CREDENTIAL_HELPER=wincred but I couldn't figure out how to do this.
Thanks for working on this! I have a patch series sitting locally for a
while that wires up all credential helpers and more, as well. It also
wires up netrc and fixes its tests to allow out-of-tree testing, which
doesn't work right now. What I don't have though is the patch for the
wincred helper.
The patch series is currently still blocked on [1], which is why I have
been holding back on it. Would you mind if I picked your patch to fix
wincred, but we then wait with wiring up remaining credential helpers
until my follow-up patch series is unblocked?
Meanwhile, I'd appreciate any feedback on [1] to help move it forward,
if you have the time :)
Patrick
[1]: <[email protected]> |
|
This branch is now known as |
|
This patch series was integrated into seen via git@1372d05. |
|
There was a status update in the "New Topics" section about the branch On hold. source: <[email protected]> |
|
There was a status update in the "Discarded" section about the branch Superseded by the ps/meson-contrib-bits topic. source: <[email protected]> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be neat to also run test t0303-credential-external with GIT_TEST_CREDENTIAL_HELPER=wincred but I couldn't figure out how to do this.
CC: Patrick Steinhardt <[email protected]