Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

405 clang format revisit rules to make the job easier to follow #1815

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Commits on Oct 8, 2024

  1. clang-format: don't enforce the column limit

    The current value for the column limit is set to 80. While this is as
    expected, we often prefer readability over this strict limit. This means
    it is common to find code which extends over 80 characters. So let's
    change the column limit to be 0 instead. This ensures that the formatter
    doesn't complain about code strictly not following the column limit.
    
    Signed-off-by: Karthik Nayak <[email protected]>
    KarthikNayak committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    34cd0c2 View commit details
    Browse the repository at this point in the history
  2. clang-format: don't align expressions after linebreaks

    We enforce alignment of expressions after linebreaks. Which means for
    code such as
    
        return a || b;
    
    it will expect:
    
       return a ||
              b;
    
    we instead want 'b' to be indent with tabs, which is already done by the
    'ContinuationIndentWidth' variable. So let's explicitly set
    'AlignOperands' to false.
    
    Signed-off-by: Karthik Nayak <[email protected]>
    KarthikNayak committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    3557012 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2024

  1. test

    KarthikNayak committed Oct 9, 2024
    Configuration menu
    Copy the full SHA
    1a6221f View commit details
    Browse the repository at this point in the history