Support UCRT64 in check-for-missing-dlls#716
Merged
Merged
Conversation
To allow specifying MINGW packages to be excluded in a convenient manner, the `mingw-w64-` prefix is automatically expanded to a pattern that matches the various architectures. Include UCRT64 in that pattern. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
The `pdftotext` dependencies are somewhat special, as they include the C++ standard library that we specifically want to exclude in MinGit, but have to include in regular Git for Windows because `pdftotext.exe` depends on it (and `WhoUses.exe`, too). But that is a GCC-specific issue, as the Clang-based builds we use for Windows/ARM64 do not want that handling. UCRT64 _is_ GCC-specific, so we want to include _that_ in that handling. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Tons of exclusions started out as `mingw..` regular expressions, matching both `/mingw64/` and `/mingw32/`. When CLANGARM64 joined the fray, these patterns were extended to also match `clang*` (seeing as `clang64` might be something we'd also want to match). Now that UCRT64 is coming along for the ride, we _could_ add all of those patterns to also match `/ucrt64/`. But this is as good an opportunity as any to instead be precise in what we want: We do not want to exclude `/clangarm64/` files in MINGW64, for example, as that would hide some undesirable payload. Instead, we basically want to match the MINGW_PREFIX (which this script knows as `/$MSYSTEM_LOWER`). Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Now that the `make-file-list.sh` file is prepared for that flavor, we should ensure that it stays that way by running this check in all PRs. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed over in git-for-windows/git-sdk-64#117 that the
check-for-missing-dllsjob failed. That's because the script needed some adjustment. (Themake-file-list.shscript, to be precise.)