installer: fix compilation when no experimental options are enabled#712
Merged
dscho merged 1 commit intoJun 11, 2026
Merged
Conversation
When HAVE_EXPERIMENTAL_OPTIONS is undefined, the Inno Setup compiler fails with "Unknown identifier 'ExperimentalOptionsPage'". Wrap the remaining references to ExperimentalOptionsPage in #ifdef blocks to ensure the installer compiles successfully in environments where all experimental features are disabled. Signed-off-by: Jason Zbakh <jzbakh@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When
HAVE_EXPERIMENTAL_OPTIONSis undefined the Inno Setup compiler fails with the following error:Unknown identifier 'ExperimentalOptionsPage'Technical Fix
Wrap the remaining references to
ExperimentalOptionsPagein#ifdef HAVE_EXPERIMENTAL_OPTIONSblocks. This ensures the installer compiles successfully in environments where all experimental features are disabled.